Page MenuHomePhabricator

Fire TransactionRemovedFromMempool from mempool
ClosedPublic

Authored by deadalnix on Jun 8 2020, 13:20.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCd66d5d7efd08: Fire TransactionRemovedFromMempool from mempool
Summary

This commit fires TransactionRemovedFromMempool callbacks from the
mempool and cleans up a bunch of code.

This is a backport of Core PR14384

policyestimator_tests was modified to use TestingSetup because it uses the CTxMemPool::TrimToSize function which now may trigger the signal, but the signals handlers are not setup properly to do so using BasicTestingSetup.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Jun 8 2020, 14:45