Page MenuHomePhabricator

[mempool] Remove NotifyEntryAdded and NotifyEntryRemoved callbacks
ClosedPublic

Authored by PiRK on Mon, Jan 11, 10:45.

Details

Summary

NotifyEntryAdded never had any subscribers so can be removed.

Since ConnectTrace no longer subscribes to NotifyEntryRemoved, there are
now no subscribers.

The CValidationInterface TransactionAddedToMempool and
TransactionRemovedFromMempool methods can now provide this
functionality. There's no need for a special notifications framework for
the mempool.

This concludes backport of Core PR17477 [6/6]
https://github.com/bitcoin/bitcoin/pull/17477/commits/e57980b4738c10344baf136de3e050a3cb958ca5
Depends on D8867

Note: See D6451 for why NotifyEntryRemoved has to be removed twice. It was probably duplicated by mistake.

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

PiRK requested review of this revision.Mon, Jan 11, 10:45

remove extra blank line added by mistake

This revision is now accepted and ready to land.Mon, Jan 11, 13:20