Paths

Table of Contentst

Differential D8869

[mempool] Remove NotifyEntryAdded and NotifyEntryRemoved callbacks
ClosedPublic
Actions

Authored by PiRK on Jan 11 2021, 10:45.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC0f542ee72ef5: [mempool] Remove NotifyEntryAdded and NotifyEntryRemoved callbacks

Summary

NotifyEntryAdded never had any subscribers so can be removed.

Since ConnectTrace no longer subscribes to NotifyEntryRemoved, there are
now no subscribers.

The CValidationInterface TransactionAddedToMempool and
TransactionRemovedFromMempool methods can now provide this
functionality. There's no need for a special notifications framework for
the mempool.

This concludes backport of Core PR17477 [6/6]
https://github.com/bitcoin/bitcoin/pull/17477/commits/e57980b4738c10344baf136de3e050a3cb958ca5
Depends on D8867

Note: See D6451 for why NotifyEntryRemoved has to be removed twice. It was probably duplicated by mistake.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 11 2021, 10:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 11 2021, 10:45

PiRK requested review of this revision.Jan 11 2021, 10:45

teamcity edited the summary of this revision. (Show Details)Jan 11 2021, 10:45

remove extra blank line added by mistake

Harbormaster completed remote builds in B14695: Diff 26839.Jan 11 2021, 11:15

Harbormaster completed remote builds in B14696: Diff 26840.Jan 11 2021, 11:25

PiRK edited the summary of this revision. (Show Details)Jan 11 2021, 13:00

PiRK added a parent revision: D8867: [validation] Remove NotifyEntryRemoved callback from ConnectTrace.

majcosta accepted this revision.Jan 11 2021, 13:20

This revision is now accepted and ready to land.Jan 11 2021, 13:20

Closed by commit rABC0f542ee72ef5: [mempool] Remove NotifyEntryAdded and NotifyEntryRemoved callbacks (authored by John Newbery <john@johnnewbery.com>, committed by PiRK). · Explain WhyJan 11 2021, 14:26

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC0f542ee72ef5: [mempool] Remove NotifyEntryAdded and NotifyEntryRemoved callbacks.

Revision Contents
Changeset List

Path

Size

src/

1 line

interfaces/

2 lines

5 lines

6 lines

Diff 26853

src/init.cpp

Loading...

src/interfaces/node.cpp

Loading...

src/txmempool.h

Loading...

src/txmempool.cpp

Loading...