Paths

Table of Contentst

Differential D8866

[validation] Remove conflictedTxs from PerBlockConnectTrace
ClosedPublic
Actions

Authored by PiRK on Jan 11 2021, 10:36.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC03fe1825fa5d: [validation] Remove conflictedTxs from PerBlockConnectTrace

Summary

Since we don't add a vtxConflicted vector to BlockConnected the
conflictedTxs member of PerBlockConnectTrace is no longer used.

This is a backport of Core PR17477 [3/6]
https://github.com/bitcoin/bitcoin/pull/17477/commits/5613f9842b4000fed088b8cf7b99674c328d15e1
Depends on D8865

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 11 2021, 10:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 11 2021, 10:36

PiRK requested review of this revision.Jan 11 2021, 10:36

teamcity edited the summary of this revision. (Show Details)Jan 11 2021, 10:37

PiRK edited the summary of this revision. (Show Details)Jan 11 2021, 10:38

PiRK added a child revision: D8867: [validation] Remove NotifyEntryRemoved callback from ConnectTrace.Jan 11 2021, 10:39

Harbormaster completed remote builds in B14692: Diff 26836.Jan 11 2021, 11:00

majcosta accepted this revision.Jan 11 2021, 12:05

This revision is now accepted and ready to land.Jan 11 2021, 12:05

Closed by commit rABC03fe1825fa5d: [validation] Remove conflictedTxs from PerBlockConnectTrace (authored by John Newbery <john@johnnewbery.com>, committed by PiRK). · Explain WhyJan 11 2021, 14:21

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC03fe1825fa5d: [validation] Remove conflictedTxs from PerBlockConnectTrace.

Revision Contents
Changeset List

Path

Size

src/

18 lines

Diff 26851

src/validation.cpp

Loading...