HomePhabricator

Don't return stale data from CCoinsViewCache::Cursor()

Authored by Russell Yanofsky <russ@yanofsky.org> on Jun 7 2017, 17:00.

Description

Don't return stale data from CCoinsViewCache::Cursor()

Summary:
CCoinsViewCache doesn't actually support cursor iteration returning the
current contents of the cache, so raise an error when the cursor method is
called instead of returning a cursor that iterates over stale data.

Also update the gettxoutsetinfo RPC which was relying on the old behavior to be
explicit about which view it is returning data about.

This is a backport of Core PR10550

Test Plan:

make check

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Subscribers: teamcity

Differential Revision: https://reviews.bitcoinabc.org/D1906

Details

Committed
deadalnixOct 9 2018, 19:27
Pushed
deadalnixOct 9 2018, 19:27
Reviewer
Restricted Project
Differential Revision
D1906: Don't return stale data from CCoinsViewCache::Cursor()
Parents
rABCb6470ce2ad17: Fix -Wthread-safety-analysis warnings. Compile with -Wthread-safety-analysis if…
Branches
Unknown
Tags
Unknown

Event Timeline