Page MenuHomePhabricator

Don't return stale data from CCoinsViewCache::Cursor()
ClosedPublic

Authored by deadalnix on Oct 9 2018, 15:52.

Details

Summary

CCoinsViewCache doesn't actually support cursor iteration returning the
current contents of the cache, so raise an error when the cursor method is
called instead of returning a cursor that iterates over stale data.

Also update the gettxoutsetinfo RPC which was relying on the old behavior to be
explicit about which view it is returning data about.

This is a backport of Core PR10550

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Oct 9 2018, 15:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 9 2018, 15:52
jasonbcox accepted this revision.Oct 9 2018, 17:30
This revision is now accepted and ready to land.Oct 9 2018, 17:30
This revision was automatically updated to reflect the committed changes.