Paths

Table of Contentst

test: Remove no longer needed MakeChain calls
e2fe3b8441b9
Actions

Description

test: Remove no longer needed MakeChain calls

Summary:
These calls are no longer needed after edc3160
from #19098 which started instantiating BasicTestingSetup.m_node.chain

Co-authored-by: MarcoFalke <falke.marco@gmail.com>

This is a backport of core#19425 [3/3]
https://github.com/bitcoin/bitcoin/pull/19425/commits/5baa88fd38c8efa0e361636bb2c60af89d27b5d5

Depends on D11419

Test Plan: ninja check

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D11420

Details

Provenance

PiRK	Authored on May 5 2022, 14:40
PiRK	Pushed on May 5 2022, 16:42

Reviewer

Restricted Project

Differential Revision

D11420: test: Remove no longer needed MakeChain calls

Parents

rABC5780de4ba17d: refactor: Replace uses ChainActive() in interfaces/chain.cpp

Branches

Unknown

Tags

Unknown

Event Timeline

PiRK committed rABCe2fe3b8441b9: test: Remove no longer needed MakeChain calls (authored by PiRK).May 5 2022, 16:42

PiRK added an edge: D11420: test: Remove no longer needed MakeChain calls.

teamcity mentioned this in T2440: Build Bitcoin-ABC / Master / Benchmarking is broken..May 5 2022, 16:59

teamcity mentioned this in T2442: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Windows 64-bit is broken..May 5 2022, 18:10

Changes (9)

Path

Size

src/

test/

interfaces_tests.cpp

wallet/

test/

coinselector_tests.cpp

init_test_fixture.cpp

init_test_fixture.h

ismine_tests.cpp

scriptpubkeyman_tests.cpp

wallet_test_fixture.cpp

wallet_test_fixture.h

wallet_tests.cpp

rABCe2fe3b8441b9

View Options

src/test/interfaces_tests.cpp

View Options

src/wallet/test/coinselector_tests.cpp

View Options

src/wallet/test/init_test_fixture.cpp

View Options

src/wallet/test/init_test_fixture.h

View Options

src/wallet/test/ismine_tests.cpp

View Options

src/wallet/test/scriptpubkeyman_tests.cpp

View Options

src/wallet/test/wallet_test_fixture.cpp

View Options

src/wallet/test/wallet_test_fixture.h

View Options

src/wallet/test/wallet_tests.cpp

test: Remove no longer needed MakeChain callse2fe3b8441b9Actions

Description

Details

Event Timeline

Changes (9)

rABCe2fe3b8441b9

src/test/interfaces_tests.cpp

src/wallet/test/coinselector_tests.cpp

src/wallet/test/init_test_fixture.cpp

src/wallet/test/init_test_fixture.h

src/wallet/test/ismine_tests.cpp

src/wallet/test/scriptpubkeyman_tests.cpp

src/wallet/test/wallet_test_fixture.cpp

src/wallet/test/wallet_test_fixture.h

src/wallet/test/wallet_tests.cpp

test: Remove no longer needed MakeChain calls
e2fe3b8441b9
Actions