HomePhabricator

refactor: Fix implicit value conversion in formatPingTime

Description

refactor: Fix implicit value conversion in formatPingTime

Summary:

This changes CNodeStats to handle ping timestamps as their original
incoming usec int64_t values until the time they need to be displayed.

Backport of core PR18260.

This fix an implicit conversion warning from Clang.

Test Plan:
With clang as a compiler:

ninja check

Check the warning is gone.

./src/qt/bitcoin-qt

Under the debug console => peer table, check the ping times look
correct.

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6277

Details

Provenance
Ben Woosley <ben.woosley@gmail.com>Authored on Mar 3 2020, 13:35
FabienCommitted on May 28 2020, 12:49
FabienPushed on May 28 2020, 12:49
Reviewer
Restricted Project
Differential Revision
D6277: refactor: Fix implicit value conversion in formatPingTime
Parents
rABC27fcccc7d329: Fix deprecated copy warning for PrecomputedTransactionData
Branches
Unknown
Tags
Unknown