Page MenuHomePhabricator
Differential D6277

refactor: Fix implicit value conversion in formatPingTime
ClosedPublic
Actions

Authored by Fabien on May 28 2020, 12:11.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCe61415e7b52c: refactor: Fix implicit value conversion in formatPingTime
Summary
This changes CNodeStats to handle ping timestamps as their original
incoming usec int64_t values until the time they need to be displayed.

Backport of core PR18260.

This fix an implicit conversion warning from Clang.

Test Plan

With clang as a compiler:

ninja check

Check the warning is gone.

./src/qt/bitcoin-qt

Under the debug console => peer table, check the ping times look
correct.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.May 28 2020, 12:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 28 2020, 12:11
Fabien requested review of this revision.May 28 2020, 12:11
teamcity edited the summary of this revision. (Show Details)May 28 2020, 12:11

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 28 2020, 12:11

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 28 2020, 12:11

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 28 2020, 12:11

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 28 2020, 12:14

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 28 2020, 12:16

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 28 2020, 12:22

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11062: Diff 20661.May 28 2020, 12:22
deadalnix accepted this revision.May 28 2020, 12:28
This revision is now accepted and ready to land.May 28 2020, 12:28
Closed by commit rABCe61415e7b52c: refactor: Fix implicit value conversion in formatPingTime (authored by Ben Woosley <ben.woosley@gmail.com>, committed by Fabien). · Explain WhyMay 28 2020, 12:49
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCe61415e7b52c: refactor: Fix implicit value conversion in formatPingTime.

Revision Contents
Changeset List

PathSize
src/
6 lines
6 lines
qt/
8 lines
7 lines
4 lines
6 lines
rpc/
13 lines

Diff 20665

View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...
View Options

src/qt/guiutil.h

Loading...
View Options

src/qt/guiutil.cpp

Loading...
View Options

src/qt/peertablemodel.cpp

Loading...
View Options

src/qt/rpcconsole.cpp

Loading...
View Options

src/rpc/net.cpp

Loading...