Page MenuHomePhabricator

refactor: Fix implicit value conversion in formatPingTime
ClosedPublic

Authored by Fabien on May 28 2020, 12:11.

Details

Summary
This changes CNodeStats to handle ping timestamps as their original
incoming usec int64_t values until the time they need to be displayed.

Backport of core PR18260.

This fix an implicit conversion warning from Clang.

Test Plan

With clang as a compiler:

ninja check

Check the warning is gone.

./src/qt/bitcoin-qt

Under the debug console => peer table, check the ping times look
correct.

Event Timeline

Fabien requested review of this revision.May 28 2020, 12:11

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.May 28 2020, 12:28