HomePhabricator

[backport#17318] replace asserts in RPC code with CHECK_NONFATAL and add linter

Description

[backport#17318] replace asserts in RPC code with CHECK_NONFATAL and add linter

Summary:
replace asserts in RPC code with CHECK_NONFATAL and add linter (Adam Jonas)

Pull request description:


Depends on D7402

Backport of Core PR17318

Test Plan:

ninja check check-functional

For the linter, change a CHECK_NONFATAL back to assertion on a file inside the src/rpc diretory, an rpcXXXXX.cpp file in src/wallet and another file in the latter directory whose filename _does not_ start with 'rpc'

only the first two should trigger the new linter's error

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D7405

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Nov 4 2019, 16:33
majcostaCommitted on Sep 8 2020, 23:26
majcostaPushed on Sep 8 2020, 23:26
Reviewer
Restricted Project
Differential Revision
D7405: [backport#17318] replace asserts in RPC code with CHECK_NONFATAL and add linter
Parents
rABC3e29d52fc39e: [backport#16285] rpc: Improve scantxoutset response and help message
Branches
Unknown
Tags
Unknown