Page MenuHomePhabricator

[backport#17318] replace asserts in RPC code with CHECK_NONFATAL and add linter
ClosedPublic

Authored by majcosta on Sep 8 2020, 21:21.

Details

Summary

replace asserts in RPC code with CHECK_NONFATAL and add linter (Adam Jonas)

Pull request description:


Depends on D7402

Backport of Core PR17318

Test Plan
ninja check check-functional

For the linter, change a CHECK_NONFATAL back to assertion on a file inside the src/rpc diretory, an rpcXXXXX.cpp file in src/wallet and another file in the latter directory whose filename _does not_ start with 'rpc'

only the first two should trigger the new linter's error

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta requested review of this revision.Sep 8 2020, 21:21

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Sep 8 2020, 22:25