HomePhabricator

depends: Allow building with system clang

Description

depends: Allow building with system clang

Summary:

This patchset allows us to force depends to use system clang.

Previously, #17099 removes our dependency on a specific clang we
download from llvm.org, but theuni pointed out that since OSX builds are
only ever built with a version of clang that is chosen and "blessed" by
Apple, it is more likely that the user will encounter problems if they
use their system clang. This patchset forces the user to set
FORCE_USE_SYSTEM_CLANG=1 in order to use their system clang (when they
know what they're doing)

Backport of core PR17919.

Test Plan:

make FORCE_USE_SYSTEM_CLANG=1 build-osx

Note that this diff isn't enough to cross build OSX with the system
clang as the toolchain file will redirect the binutils to the ones from
the depends.

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D7755

Details

Provenance
Carl Dong <contact@carldong.me>Authored on Oct 10 2019, 00:10
FabienCommitted on Oct 6 2020, 04:55
FabienPushed on Oct 6 2020, 04:55
Reviewer
Restricted Project
Differential Revision
D7755: depends: Allow building with system clang
Parents
rABC6f59a8facadb: [CMAKE] Fix version in the man2html template
Branches
Unknown
Tags
Unknown