Page MenuHomePhabricator

depends: Allow building with system clang
ClosedPublic

Authored by Fabien on Oct 5 2020, 08:16.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCf3bc63937c3c: depends: Allow building with system clang
Summary
This patchset allows us to force depends to use system clang.

Previously, #17099 removes our dependency on a specific clang we
download from llvm.org, but theuni pointed out that since OSX builds are
only ever built with a version of clang that is chosen and "blessed" by
Apple, it is more likely that the user will encounter problems if they
use their system clang. This patchset forces the user to set
FORCE_USE_SYSTEM_CLANG=1 in order to use their system clang (when they
know what they're doing)

Backport of core PR17919.

Test Plan
make FORCE_USE_SYSTEM_CLANG=1 build-osx

Note that this diff isn't enough to cross build OSX with the system
clang as the toolchain file will redirect the binutils to the ones from
the depends.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Oct 5 2020, 08:16

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

binutils_path in the base Makefile?

It is only used for the generation of the config.site file which has been removed.

This revision is now accepted and ready to land.Oct 5 2020, 20:17