HomePhabricator

Fix incorrect node being checked in segwit recovery test

Authored by jasonbcox on Mon, Aug 12, 20:57.

Description

Fix incorrect node being checked in segwit recovery test

Summary:
Discovered while working on backports related to send_txs_and_test.
Before this patch, the test happens to pass because the check at line 270 is looking for a tx not being in the mempool of node0, when it should be checking node1 (see calls to check_for_no_ban_on_rejected_tx on node_std at line 270-273).

Test Plan: test_runner.py abc-segwit-recovery

Reviewers: #bitcoin_abc, deadalnix, markblundeberg

Reviewed By: #bitcoin_abc, markblundeberg

Subscribers: markblundeberg

Differential Revision: https://reviews.bitcoinabc.org/D3859

Details

Committed
jasonbcoxMon, Aug 12, 23:20
Pushed
jasonbcoxMon, Aug 12, 23:20
Reviewer
Restricted Project
Differential Revision
D3859: Fix incorrect node being checked in segwit recovery test
Parents
rABC61b72926bc84: Merge #11617: Avoid lock: Call FlushStateToDisk(...) regardless of…
Branches
Unknown
Tags
Unknown