Page MenuHomePhabricator

Fix incorrect node being checked in segwit recovery test

Authored by jasonbcox on Mon, Aug 12, 21:01.



Discovered while working on backports related to send_txs_and_test.
Before this patch, the test happens to pass because the check at line 270 is looking for a tx not being in the mempool of node0, when it should be checking node1 (see calls to check_for_no_ban_on_rejected_tx on node_std at line 270-273).

Test Plan abc-segwit-recovery

Diff Detail

rABC Bitcoin ABC
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Mon, Aug 12, 21:01
markblundeberg accepted this revision.Mon, Aug 12, 22:12
markblundeberg added a subscriber: markblundeberg.

oops! that was me :)

This revision is now accepted and ready to land.Mon, Aug 12, 22:12