Page MenuHomePhabricator

Fix incorrect node being checked in segwit recovery test
ClosedPublic

Authored by jasonbcox on Aug 12 2019, 21:01.

Details

Summary

Discovered while working on backports related to send_txs_and_test.
Before this patch, the test happens to pass because the check at line 270 is looking for a tx not being in the mempool of node0, when it should be checking node1 (see calls to check_for_no_ban_on_rejected_tx on node_std at line 270-273).

Test Plan

test_runner.py abc-segwit-recovery

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.