HomePhabricator

[arclint] Lint web/e.cash

Description

[arclint] Lint web/e.cash

Summary:
NextJS has its own special eslint configuration. It's run automatically on build. However, it is not run directly with eslint, the same way that .arclint and other JS repos run.

This was causing lint issues to be missed until CI ran npm run build, triggering the special next lint in CI.

arc lint was throwing a module not found error for the special nextjs dependencies. I corrected this by following a solution recommended here: https://github.com/vercel/next.js/issues/40687

Test Plan: Add quotation marks to a /web/e.cash/pages/careers.js. Note lint errors, in VScode if you are using it, or by running arc lint

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D14668

Details

Provenance
bytesofmanAuthored on Oct 23 2023, 19:59
bytesofmanPushed on Oct 24 2023, 12:34
Reviewer
Restricted Project
Differential Revision
D14668: [arclint] Lint web/e.cash
Parents
rABCabaa3264e028: [Automated] Update seeds
Branches
Unknown
Tags
Unknown