Page MenuHomePhabricator
Differential D14668

[arclint] Lint web/e.cash
ClosedPublic
Actions

Authored by bytesofman on Oct 23 2023, 20:02.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf7a63af3afd6: [arclint] Lint web/e.cash
Summary

NextJS has its own special eslint configuration. It's run automatically on build. However, it is not run directly with eslint, the same way that .arclint and other JS repos run.

This was causing lint issues to be missed until CI ran npm run build, triggering the special next lint in CI.

arc lint was throwing a module not found error for the special nextjs dependencies. I corrected this by following a solution recommended here: https://github.com/vercel/next.js/issues/40687

Test Plan

Add quotation marks to a /web/e.cash/pages/careers.js. Note lint errors, in VScode if you are using it, or by running arc lint

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Oct 23 2023, 20:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 23 2023, 20:02
bytesofman requested review of this revision.Oct 23 2023, 20:02
Harbormaster completed remote builds in B25400: Diff 42735.Oct 23 2023, 20:02
bytesofman updated this revision to Diff 42736.Oct 23 2023, 20:03

remove copy paste instructions from ported solution

Harbormaster completed remote builds in B25401: Diff 42736.Oct 23 2023, 20:03
Fabien requested changes to this revision.Oct 24 2023, 08:15
Fabien added a subscriber: Fabien.
Fabien added inline comments.
web/e.cash/.eslintrc.js
12 ↗(On Diff #42736)

It's worth commenting on that, even linking to the github for reference

This revision now requires changes to proceed.Oct 24 2023, 08:15
bytesofman updated this revision to Diff 42744.Oct 24 2023, 12:03

improve comments, remove unnecessary array

Harbormaster completed remote builds in B25409: Diff 42744.Oct 24 2023, 12:03
Fabien accepted this revision.Oct 24 2023, 12:23
This revision is now accepted and ready to land.Oct 24 2023, 12:23
Closed by commit rABCf7a63af3afd6: [arclint] Lint web/e.cash (authored by bytesofman). · Explain WhyOct 24 2023, 12:34
This revision was automatically updated to reflect the committed changes.
bytesofman marked an inline comment as done.
bytesofman added a commit: rABCf7a63af3afd6: [arclint] Lint web/e.cash.

Revision Contents
Changeset List

PathSize
3 lines
web/
e.cash/
14 lines

Diff 42745

View Options

.arclint

Loading...
View Options

web/e.cash/.eslintrc.js

Loading...