Page MenuHomePhabricator

[arclint] Lint web/e.cash
ClosedPublic

Authored by bytesofman on Oct 23 2023, 20:02.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf7a63af3afd6: [arclint] Lint web/e.cash
Summary

NextJS has its own special eslint configuration. It's run automatically on build. However, it is not run directly with eslint, the same way that .arclint and other JS repos run.

This was causing lint issues to be missed until CI ran npm run build, triggering the special next lint in CI.

arc lint was throwing a module not found error for the special nextjs dependencies. I corrected this by following a solution recommended here: https://github.com/vercel/next.js/issues/40687

Test Plan

Add quotation marks to a /web/e.cash/pages/careers.js. Note lint errors, in VScode if you are using it, or by running arc lint

Diff Detail

Repository
rABC Bitcoin ABC
Branch
add-ecash-to-arclint
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25401
Build 50383: Build Diff
Build 50382: arc lint + arc unit

Event Timeline

remove copy paste instructions from ported solution

Fabien requested changes to this revision.Oct 24 2023, 08:15
Fabien added a subscriber: Fabien.
Fabien added inline comments.
web/e.cash/.eslintrc.js
12

It's worth commenting on that, even linking to the github for reference

This revision now requires changes to proceed.Oct 24 2023, 08:15

improve comments, remove unnecessary array

This revision is now accepted and ready to land.Oct 24 2023, 12:23
This revision was automatically updated to reflect the committed changes.
bytesofman marked an inline comment as done.