HomePhabricator

[script_tests] add small NUM2BIN case

Description

[script_tests] add small NUM2BIN case

Summary:
Implementors may be tempted to have NUM2BIN bail out early if the
input is already of the requested size, however this is incorrect--
in the case of a "negative zero" representation, NUM2BIN must flip
the sign bit.

Test Plan: make check

Reviewers: deadalnix, Fabien, jasonbcox, #bitcoin_abc

Reviewed By: deadalnix, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D3610

Details

Provenance
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>Authored on Jul 9 2019, 14:27
markblundebergPushed on Jul 9 2019, 18:15
Reviewer
Restricted Project
Differential Revision
D3610: [script_tests] add small NUM2BIN case
Parents
rABCb911146913f1: Various nits in the wallet code
Branches
Unknown
Tags
Unknown

Event Timeline

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABCfb6523889606: [script_tests] add small NUM2BIN case (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).Jul 9 2019, 18:15