[script_tests] add small NUM2BIN case
ClosedPublic
Actions

Authored by markblundeberg on Jul 9 2019, 14:35.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGfb6523889606: [script_tests] add small NUM2BIN case
rABCfb6523889606: [script_tests] add small NUM2BIN case

Summary

Implementors may be tempted to have NUM2BIN bail out early if the
input is already of the requested size, however this is incorrect--
in the case of a "negative zero" representation, NUM2BIN must flip
the sign bit.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markblundeberg created this revision.Jul 9 2019, 14:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 9 2019, 14:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

I've checked a variety of other implementations (bchd, verde, BU) and none are performing the incorrect bail-early optimization I suggest here, but you never know, someone might think it's a "clever" idea one day.

Harbormaster completed remote builds in B6758: Diff 10131.Jul 9 2019, 14:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

markblundeberg retitled this revision from add small NUM2BIN test case to [script_tests] add small NUM2BIN case.Jul 9 2019, 16:22

deadalnix accepted this revision.Jul 9 2019, 17:27

This revision is now accepted and ready to land.Jul 9 2019, 17:27

Closed by commit rABCfb6523889606: [script_tests] add small NUM2BIN case (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyJul 9 2019, 18:15

This revision was automatically updated to reflect the committed changes.

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABCfb6523889606: [script_tests] add small NUM2BIN case.

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGINGfb6523889606: [script_tests] add small NUM2BIN case.Sep 19 2019, 01:06