HomePhabricator

[Cashtab] Compare latest utxo set to stored wallet state

Description

[Cashtab] Compare latest utxo set to stored wallet state

Summary:
If wallet has utxo set in state, then the utxosHaveChanged check should be performed against wallet.state and not previousUtxos

Issue: If user activates a new wallet from their saved wallets, utxosChanged will always be true if the app is checking previousUtxos instead of the previous utxo state of the loaded wallet.

After more local testing, turns out the issue described in D9516 was not happening in general, but only in a specific case being tested locally. So, this diff restores the original functionality, while keeping the cleaned up syntax of D9516.

Test Plan: npm test

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Differential Revision: https://reviews.bitcoinabc.org/D9521

Details

Provenance
Joey King <joseph.roy.king@gmail.com>Authored on May 13 2021, 13:59
bytesofmanPushed on May 13 2021, 15:08
Reviewer
Restricted Project
Differential Revision
D9521: [Cashtab] Compare latest utxo set to stored wallet state
Parents
rABC9ae1d72c46a9: [backport#19489] test: Fail wait_until early if connection is lost
Branches
Unknown
Tags
Unknown