HomePhabricator

doc: Properly report optional RPC args

Description

doc: Properly report optional RPC args

Summary:

OMITTED_NAMED_ARG and OMITTED are a confusing burden:

    It puts the burden on developers to pick the right one of the two
    They can be interchanged without introducing a compile failure or other error
    Picking the wrong one is leading to incorrect docs
    They are redundant, because the correct one can already be determined by the surrounding type

Fix all issues by making them an alias of each other; Pick the right one based on the outer type.

Backport of core#26706.

Depends on D16314.

Test Plan:

ninja all check-all

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D16315

Details

Provenance
MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>Authored on Jan 3 2023, 12:09
FabienCommitted on Jun 10 2024, 07:22
teamcityPushed on Jun 10 2024, 07:24
Parents
rSTAGINGfe8c891d9d2e: rpc: Throw more user friendly arg type check error
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/48201

Event Timeline