Diffusion Bitcoin ABC staging 0e31ab2753c0

Make error message more meaningful when a block contains a duplicate transaction
0e31ab2753c0
Actions

Description

Make error message more meaningful when a block contains a duplicate transaction

Summary: It also allows to bail early thanks to CTOR.

Test Plan: Added tests cases.

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Subscribers: jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D2076

Details

Provenance

deadalnix	Authored on Nov 17 2018, 01:52
schancel	Pushed on Nov 17 2018, 05:18

Reviewer

Restricted Project

Differential Revision

D2076: Make error message more meaningful when a block contains a duplicate transaction

Parents

rSTAGING2b4be88522d4: Fix transaction ordering in abc-mempool-accept-txn

Branches

Unknown

Tags

Unknown

References

Event Timeline

deadalnix committed rSTAGING0e31ab2753c0: Make error message more meaningful when a block contains a duplicate transaction (authored by deadalnix).Nov 17 2018, 02:50

Changes (4)

Path

Size

src/

test/

uint256_tests.cpp

uint256.h

validation.cpp

test/

functional/

abc-transaction-ordering.py

rSTAGING0e31ab2753c0

View Options

src/test/uint256_tests.cpp

View Options

src/uint256.h

View Options

src/validation.cpp

View Options

test/functional/abc-transaction-ordering.py

Make error message more meaningful when a block contains a duplicate transaction0e31ab2753c0Actions

Description

Details

Event Timeline

Changes (4)

rSTAGING0e31ab2753c0

src/test/uint256_tests.cpp

src/uint256.h

src/validation.cpp

test/functional/abc-transaction-ordering.py

Make error message more meaningful when a block contains a duplicate transaction
0e31ab2753c0
Actions