HomePhabricator

Move current coin selection algorithm to coinselection.{cpp,h}

Description

Move current coin selection algorithm to coinselection.{cpp,h}

Summary:
Moves the current coin selection algorithm out of SelectCoinsMinConf
and puts it in coinselection.{cpp,h}. The new function, KnapsackSolver,
instead of taking a vector of COutputs, will take a vector of CInputCoins
that is prepared by SelectCoinsMinConf.

This is a partial backport of Core PR10637 : https://github.com/bitcoin/bitcoin/pull/10637/commits/fb716f7b25927e377f73b904a88ab67facfe3e55

Depends on D3246 and D3250

Test Plan:

make check

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D3289

Details

Provenance
Andrew Chow <achow101-github@achow101.com>Authored on Mar 10 2018, 03:51
deadalnixCommitted on Jun 13 2019, 13:03
deadalnixPushed on Jun 13 2019, 13:08
Reviewer
Restricted Project
Differential Revision
D3289: Move current coin selection algorithm to coinselection.{cpp,h}
Parents
rSTAGING1716c33e056b: Benchmark BnB in the worst case where it exhausts
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/9389