Page MenuHomePhabricator

Remove coinselection.h -> wallet.h circular dependency
ClosedPublic

Authored by deadalnix on Fri, Jun 7, 00:12.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf24b2f5577cf: Remove coinselection.h -> wallet.h circular dependency
Summary

Changes CInputCoin to coinselection and to use CTransactionRef in
order to avoid a circular dependency. Also moves other coin selection
specific variables out of wallet.h to coinselectoin.h

This is a partial backport of Core PR10637 : https://github.com/bitcoin/bitcoin/pull/10637/commits/4b2716da46e96c45206db869b83c28c5fc7889f4

Depends on D3245 and D3249

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Fri, Jun 7, 00:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Jun 7, 00:12
Fabien accepted this revision.Fri, Jun 7, 10:18
This revision is now accepted and ready to land.Fri, Jun 7, 10:18