Page MenuHomePhabricator
Differential D3249

Implement Branch and Bound coin selection in a new file
ClosedPublic
Actions

Authored by deadalnix on Jun 7 2019, 00:06.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING88daa3d6c4af: Implement Branch and Bound coin selection in a new file
rABC88daa3d6c4af: Implement Branch and Bound coin selection in a new file
Summary

Create a new file for coin selection logic and implement the BnB algorithm in it.

This is a partial backport of Core PR10637 : https://github.com/bitcoin/bitcoin/pull/10637/commits/0185939be6f7c5554b864e33657ce610fd434e18

Unfortunately, the test has way more dependencies, so it'll have to come separately.

Depends on D3248

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 7 2019, 00:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 7 2019, 00:06
teamcity added a comment.Jun 7 2019, 00:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix added a child revision: D3250: Remove coinselection.h -> wallet.h circular dependency.Jun 7 2019, 00:12
teamcity added a comment.Jun 7 2019, 00:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6203: Diff 9230.Jun 7 2019, 00:17
Fabien requested changes to this revision.Jun 7 2019, 10:18
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/coinselection.cpp
7 ↗(On Diff #9230)

Place first on its own line to avoid the linter to reorder

This revision now requires changes to proceed.Jun 7 2019, 10:18
deadalnix updated this revision to Diff 9357.Jun 12 2019, 14:15

Reoder includes

teamcity added a comment.Jun 12 2019, 14:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 12 2019, 14:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6286: Diff 9357.Jun 12 2019, 14:23
Fabien accepted this revision.Jun 13 2019, 08:03
This revision is now accepted and ready to land.Jun 13 2019, 08:03
Closed by commit rABC88daa3d6c4af: Implement Branch and Bound coin selection in a new file (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyJun 13 2019, 12:50
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC88daa3d6c4af: Implement Branch and Bound coin selection in a new file.
deadalnix added a commit: rSTAGING88daa3d6c4af: Implement Branch and Bound coin selection in a new file.Sep 19 2019, 00:16

Revision Contents
Changeset List

PathSize
src/
2 lines
wallet/
1 line
18 lines
205 lines
1 line
1 line

Diff 9383

View Options

src/Makefile.am

Loading...
View Options

src/wallet/CMakeLists.txt

Loading...
View Options

src/wallet/coinselection.h

Loading...
View Options

src/wallet/coinselection.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...