Page MenuHomePhabricator

Implement Branch and Bound coin selection in a new file
ClosedPublic

Authored by deadalnix on Fri, Jun 7, 00:06.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC88daa3d6c4af: Implement Branch and Bound coin selection in a new file
Summary

Create a new file for coin selection logic and implement the BnB algorithm in it.

This is a partial backport of Core PR10637 : https://github.com/bitcoin/bitcoin/pull/10637/commits/0185939be6f7c5554b864e33657ce610fd434e18

Unfortunately, the test has way more dependencies, so it'll have to come separately.

Depends on D3248

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Fri, Jun 7, 00:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Jun 7, 00:06
Fabien requested changes to this revision.Fri, Jun 7, 10:18
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/coinselection.cpp
7 ↗(On Diff #9230)

Place first on its own line to avoid the linter to reorder

This revision now requires changes to proceed.Fri, Jun 7, 10:18
deadalnix updated this revision to Diff 9357.Wed, Jun 12, 14:15

Reoder includes

Fabien accepted this revision.Thu, Jun 13, 08:03
This revision is now accepted and ready to land.Thu, Jun 13, 08:03