Page MenuHomePhabricator

Add tests for the Branch and Bound algorithm
ClosedPublic

Authored by deadalnix on Fri, Jun 7, 00:27.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC5cc81b09640d: Add tests for the Branch and Bound algorithm
Summary
Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Fri, Jun 7, 00:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Jun 7, 00:27
Fabien requested changes to this revision.Fri, Jun 7, 10:44
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/test/coinselector_tests.cpp
8 ↗(On Diff #9233)

test related includes are usually placed after other includes (match src/test pattern)

10 ↗(On Diff #9233)

dito

47 ↗(On Diff #9233)

size_t

This revision now requires changes to proceed.Fri, Jun 7, 10:44
deadalnix added inline comments.Wed, Jun 12, 14:20
src/wallet/test/coinselector_tests.cpp
47 ↗(On Diff #9233)

Because ?

deadalnix updated this revision to Diff 9359.Wed, Jun 12, 14:22

Reorder includes

Fabien added inline comments.Wed, Jun 12, 14:22
src/wallet/test/coinselector_tests.cpp
47 ↗(On Diff #9233)

nvm, It's OK

Fabien accepted this revision.Thu, Jun 13, 08:05
This revision is now accepted and ready to land.Thu, Jun 13, 08:05
This revision was automatically updated to reflect the committed changes.