Page MenuHomePhabricator

Add tests for the Branch and Bound algorithm
ClosedPublic

Authored by deadalnix on Jun 7 2019, 00:27.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Jun 7 2019, 00:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 7 2019, 00:27
Fabien requested changes to this revision.Jun 7 2019, 10:44
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/test/coinselector_tests.cpp
8 ↗(On Diff #9233)

test related includes are usually placed after other includes (match src/test pattern)

10 ↗(On Diff #9233)

dito

47 ↗(On Diff #9233)

size_t

This revision now requires changes to proceed.Jun 7 2019, 10:44
deadalnix added inline comments.Jun 12 2019, 14:20
src/wallet/test/coinselector_tests.cpp
47 ↗(On Diff #9233)

Because ?

deadalnix updated this revision to Diff 9359.Jun 12 2019, 14:22

Reorder includes

Fabien added inline comments.Jun 12 2019, 14:22
src/wallet/test/coinselector_tests.cpp
47 ↗(On Diff #9233)

nvm, It's OK

Fabien accepted this revision.Jun 13 2019, 08:05
This revision is now accepted and ready to land.Jun 13 2019, 08:05
This revision was automatically updated to reflect the committed changes.