Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING0cb6aa009058: Speedup coinselector_tests by using a dummy WalletDBWrapper when apropriate
rABC0cb6aa009058: Speedup coinselector_tests by using a dummy WalletDBWrapper when apropriate

Summary

Since the addition of AddToWallet to add_coin, some test became significantly slower due to an increase in operation done on the mock DB. Using a dummy DB when the mock is not required speeds things up dramatically.

Test Plan

perf -g -- src/test/test_bitcoin -t coinselector_tests
perf report

Make sure that the majority of the time isn't spent in BDB anymore.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 22 2019, 01:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 22 2019, 01:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix added a parent revision: D3378: Actually disable BnB when there are preset inputs.Jun 22 2019, 01:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6442: Diff 9585.Jun 22 2019, 01:30

JFC this test is slow without this patch. >_<

From what I can see, Core used a dummy wallet from the very start. Why is ours different? It looks like the backport D3252 got modified from the original somehow.

deadalnix added a child revision: D3394: wallet: Switch to using output groups instead of coins in coin selection.Jun 22 2019, 21:47

Fabien accepted this revision.Jun 24 2019, 10:11

This revision is now accepted and ready to land.Jun 24 2019, 10:11

Closed by commit rABC0cb6aa009058: Speedup coinselector_tests by using a dummy WalletDBWrapper when apropriate (authored by deadalnix). · Explain WhyJun 24 2019, 16:02

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC0cb6aa009058: Speedup coinselector_tests by using a dummy WalletDBWrapper when apropriate.

deadalnix added a commit: rSTAGING0cb6aa009058: Speedup coinselector_tests by using a dummy WalletDBWrapper when apropriate.Sep 19 2019, 00:28