Since the addition of AddToWallet to add_coin, some test became significantly slower due to an increase in operation done on the mock DB. Using a dummy DB when the mock is not required speeds things up dramatically.
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rSTAGING0cb6aa009058: Speedup coinselector_tests by using a dummy WalletDBWrapper when apropriate
rABC0cb6aa009058: Speedup coinselector_tests by using a dummy WalletDBWrapper when apropriate
perf -g -- src/test/test_bitcoin -t coinselector_tests perf report
Make sure that the majority of the time isn't spent in BDB anymore.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- knapsack_solver_test_speedup
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 6442 Build 10931: Bitcoin ABC Buildbot (legacy) Build 10930: arc lint + arc unit
Event Timeline
Comment Actions
From what I can see, Core used a dummy wallet from the very start. Why is ours different? It looks like the backport D3252 got modified from the original somehow.