Differential D3377

Fix Clang Static Analyzer warnings
ClosedPublic
Actions

Authored by deadalnix on Jun 21 2019, 01:28.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGe45beabef48d: Fix Clang Static Analyzer warnings
rABCe45beabef48d: Fix Clang Static Analyzer warnings

Summary

This is a backport of Core PR12963

Fix dead stores. Values were stored but never read. Limit scope.
Add assertion to guide static analyzers. Clang Static Analyzer needs this guidance.

Depends on D3364

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 21 2019, 01:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 21 2019, 01:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6421: Diff 9559.Jun 21 2019, 01:34

jasonbcox accepted this revision.Jun 21 2019, 21:43

This revision is now accepted and ready to land.Jun 21 2019, 21:43

deadalnix added a child revision: D3394: wallet: Switch to using output groups instead of coins in coin selection.Jun 22 2019, 21:47

Closed by commit rABCe45beabef48d: Fix Clang Static Analyzer warnings (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by deadalnix). · Explain WhyJun 24 2019, 15:50

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCe45beabef48d: Fix Clang Static Analyzer warnings.

deadalnix added a commit: rSTAGINGe45beabef48d: Fix Clang Static Analyzer warnings.Sep 19 2019, 00:28

Revision Contents
Changeset List

Path

Size

src/

rpc/

mining.cpp

1 line

test/

util_tests.cpp

1 line

wallet/

test/

coinselector_tests.cpp

15 lines

Diff 9615

View Options

src/rpc/mining.cpp

View Options

src/test/util_tests.cpp

View Options

src/wallet/test/coinselector_tests.cpp

Fix Clang Static Analyzer warningsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 9615

src/rpc/mining.cpp

src/test/util_tests.cpp

src/wallet/test/coinselector_tests.cpp

Fix Clang Static Analyzer warnings
ClosedPublic
Actions

Revision Contents
Changeset List