Page MenuHomePhabricator

Fix Clang Static Analyzer warnings
ClosedPublic

Authored by deadalnix on Jun 21 2019, 01:28.

Details

Summary

This is a backport of Core PR12963

  • Fix dead stores. Values were stored but never read. Limit scope.
  • Add assertion to guide static analyzers. Clang Static Analyzer needs this guidance.

Depends on D3364

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr12963
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6421
Build 10889: Bitcoin ABC Buildbot (legacy)
Build 10888: arc lint + arc unit