HomePhabricator

Speedup coinselector_tests by using a dummy WalletDBWrapper when apropriate

Description

Speedup coinselector_tests by using a dummy WalletDBWrapper when apropriate

Summary: Since the addition of AddToWallet to add_coin, some test became significantly slower due to an increase in operation done on the mock DB. Using a dummy DB when the mock is not required speeds things up dramatically.

Test Plan:

perf -g -- src/test/test_bitcoin -t coinselector_tests
perf report

Make sure that the majority of the time isn't spent in BDB anymore.

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: markblundeberg

Differential Revision: https://reviews.bitcoinabc.org/D3387

Details

Provenance
deadalnixAuthored on Jun 22 2019, 00:58
markblundebergPushed on Jun 24 2019, 17:22
Reviewer
Restricted Project
Differential Revision
D3387: Speedup coinselector_tests by using a dummy WalletDBWrapper when apropriate
Parents
rSTAGING740a33e83f89: Actually disable BnB when there are preset inputs
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/9618