Page MenuHomePhabricator
Differential D3252

Add tests for the Branch and Bound algorithm
ClosedPublic
Actions

Authored by deadalnix on Jun 7 2019, 00:27.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING5cc81b09640d: Add tests for the Branch and Bound algorithm
rABC5cc81b09640d: Add tests for the Branch and Bound algorithm
Summary

This ia partial backport of Core PR10637 : https://github.com/bitcoin/bitcoin/pull/10637/commits/4566ab75f277612425337bf7786c1d3a410d894a

Depends on D3250

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
branhboundtest
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6288
Build 10623: Bitcoin ABC Buildbot (legacy)
Build 10622: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 7 2019, 00:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 7 2019, 00:27
teamcity added a comment.Jun 7 2019, 00:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 7 2019, 00:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6206: Diff 9233.Jun 7 2019, 00:38
Fabien requested changes to this revision.Jun 7 2019, 10:44
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/test/coinselector_tests.cpp
8 ↗(On Diff #9233)

test related includes are usually placed after other includes (match src/test pattern)

10 ↗(On Diff #9233)

dito

47 ↗(On Diff #9233)

size_t

This revision now requires changes to proceed.Jun 7 2019, 10:44
deadalnix added a child revision: D3290: Move original knapsack solver tests to coinselector_tests.cpp.Jun 11 2019, 16:54
deadalnix added inline comments.Jun 12 2019, 14:20
src/wallet/test/coinselector_tests.cpp
47 ↗(On Diff #9233)

Because ?

deadalnix updated this revision to Diff 9359.Jun 12 2019, 14:22

Reorder includes

Fabien added inline comments.Jun 12 2019, 14:22
src/wallet/test/coinselector_tests.cpp
47 ↗(On Diff #9233)

nvm, It's OK

teamcity added a comment.Jun 12 2019, 14:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 12 2019, 14:30

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6288: Diff 9359.Jun 12 2019, 14:30
Fabien accepted this revision.Jun 13 2019, 08:05
This revision is now accepted and ready to land.Jun 13 2019, 08:05
Closed by commit rABC5cc81b09640d: Add tests for the Branch and Bound algorithm (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyJun 13 2019, 12:58
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC5cc81b09640d: Add tests for the Branch and Bound algorithm.
markblundeberg mentioned this in D3387: Speedup coinselector_tests by using a dummy WalletDBWrapper when apropriate.Jun 22 2019, 03:57
deadalnix added a commit: rSTAGING5cc81b09640d: Add tests for the Branch and Bound algorithm.Sep 19 2019, 00:16

Revision Contents
Changeset List

PathSize
src/
3 lines
test/
1 line
wallet/
2 lines
2 lines
test/
184 lines

Diff 9359

View Options

src/Makefile.test.include

Loading...
View Options

src/test/CMakeLists.txt

Loading...
View Options

src/wallet/coinselection.h

Loading...
View Options

src/wallet/coinselection.cpp

Loading...
View Options

src/wallet/test/coinselector_tests.cpp

Loading...