Page MenuHomePhabricator
Differential D3250

Remove coinselection.h -> wallet.h circular dependency
ClosedPublic
Actions

Authored by deadalnix on Jun 7 2019, 00:12.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGf24b2f5577cf: Remove coinselection.h -> wallet.h circular dependency
rABCf24b2f5577cf: Remove coinselection.h -> wallet.h circular dependency
Summary

Changes CInputCoin to coinselection and to use CTransactionRef in
order to avoid a circular dependency. Also moves other coin selection
specific variables out of wallet.h to coinselectoin.h

This is a partial backport of Core PR10637 : https://github.com/bitcoin/bitcoin/pull/10637/commits/4b2716da46e96c45206db869b83c28c5fc7889f4

Depends on D3245 and D3249

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
breakcircdep
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6287
Build 10621: Bitcoin ABC Buildbot (legacy)
Build 10620: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 7 2019, 00:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 7 2019, 00:12
teamcity added a comment.Jun 7 2019, 00:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 7 2019, 00:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6204: Diff 9231.Jun 7 2019, 00:24
deadalnix added a child revision: D3252: Add tests for the Branch and Bound algorithm.Jun 7 2019, 00:27
Fabien accepted this revision.Jun 7 2019, 10:18
This revision is now accepted and ready to land.Jun 7 2019, 10:18
deadalnix added a child revision: D3289: Move current coin selection algorithm to coinselection.{cpp,h}.Jun 11 2019, 16:24
deadalnix updated this revision to Diff 9358.Jun 12 2019, 14:18

rebase

teamcity added a comment.Jun 12 2019, 14:19

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6287: Diff 9358.Jun 12 2019, 14:27
teamcity added a comment.Jun 12 2019, 14:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix added a child revision: D3303: Benchmark BnB in the worst case where it exhausts.Jun 12 2019, 15:52
Closed by commit rABCf24b2f5577cf: Remove coinselection.h -> wallet.h circular dependency (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyJun 13 2019, 12:52
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCf24b2f5577cf: Remove coinselection.h -> wallet.h circular dependency.
deadalnix added a commit: rSTAGINGf24b2f5577cf: Remove coinselection.h -> wallet.h circular dependency.Sep 19 2019, 00:16

Revision Contents
Changeset List

PathSize
src/
wallet/
40 lines
39 lines
8 lines

Diff 9358

View Options

src/wallet/coinselection.h

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...