Page MenuHomePhabricator

Remove coinselection.h -> wallet.h circular dependency
ClosedPublic

Authored by deadalnix on Jun 7 2019, 00:12.

Details

Summary

Changes CInputCoin to coinselection and to use CTransactionRef in
order to avoid a circular dependency. Also moves other coin selection
specific variables out of wallet.h to coinselectoin.h

This is a partial backport of Core PR10637 : https://github.com/bitcoin/bitcoin/pull/10637/commits/4b2716da46e96c45206db869b83c28c5fc7889f4

Depends on D3245 and D3249

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
breakcircdep
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6287
Build 10621: Bitcoin ABC Buildbot (legacy)
Build 10620: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 7 2019, 00:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 7 2019, 00:12
Fabien accepted this revision.Jun 7 2019, 10:18
This revision is now accepted and ready to land.Jun 7 2019, 10:18