HomePhabricator

Fix ZMQ test occasional hang and modernize it
12c8a2426d36Unpublished

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

Fix ZMQ test occasional hang and modernize it

Summary:
This test hung regularly on Ubuntu 14.04, and has in particular been causing our recent Travis runs to error out due to timeouts.

This patch corrects the non-terminations of the test through the ZMQ context destruction fix added in John Newbery's Core commit 7c51e9f0dc67.

It also adapts some sections to the more recent Core version of the test, including running only 2 nodes (speeds up the test) and specifying a ZMQ socket receive timeout option.

It is the destruction of the ZMQ context that fixes the intermittent hanging problem. When the ZMQ context lingers, sys.exit(0) may not terminate the zmq_test.py program, which then causes the test runner to wait forever, which times out Travis.

Test Plan:

../qa/pull-tester/rpc-tests.py zmq_test

Run it through Travis.

Reviewers: #bitcoin_abc, deadalnix, CCulianu

Reviewed By: #bitcoin_abc, deadalnix, CCulianu

Differential Revision: https://reviews.bitcoinabc.org/D514

Details

Provenance
freetraderAuthored on Aug 31 2017, 12:49
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Reviewer
Restricted Project
Differential Revision
D514: Fix ZMQ test occasional hang and modernize it
Parents
rSTAGINGa8aab99234db: OSX: Change app bundle name and executable name to BitcoinABC-Qt.app and change…
Branches
Unknown
Tags
Unknown