HomePhabricator

Merge #11737: Document partial validation in ConnectBlock()

Description

Merge #11737: Document partial validation in ConnectBlock()

Summary:
PR11737 backport https://github.com/bitcoin/bitcoin/pull/11737/files
9d811dc Document partial validation in ConnectBlock() (Suhas Daftuar)

Pull request description:

`ConnectBlock()` relies on validation that happens in `ContextualCheckBlock()` and
`ContextualCheckBlockHeader()`. This has implications for implementing consensus
changes and handling software upgrade to ensure that nodes upgrading their
software end up enforcing all the consensus rules.

Test Plan: make check

Reviewers: deadalnix, jasonbcox, Fabien, #bitcoin_abc

Reviewed By: Fabien, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D3580

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Nov 29 2017, 11:16
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>Committed on Jul 8 2019, 13:57
nakihitoPushed on Jul 8 2019, 16:27
Reviewer
Restricted Project
Differential Revision
D3580: Merge #11737: Document partial validation in ConnectBlock()
Parents
rSTAGINGe66c645130f0: Merge #11747: Fix: Open files read only if requested
Branches
Unknown
Tags
Unknown