Merge #11737: Document partial validation in ConnectBlock()
ClosedPublic
Actions

Authored by markblundeberg on Jul 7 2019, 16:07.

Details

Reviewers

deadalnix
jasonbcox
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING19b78ad7ca3c: Merge #11737: Document partial validation in ConnectBlock()
rABC19b78ad7ca3c: Merge #11737: Document partial validation in ConnectBlock()

Summary

PR11737 backport https://github.com/bitcoin/bitcoin/pull/11737/files
9d811dc Document partial validation in ConnectBlock() (Suhas Daftuar)

Pull request description:

`ConnectBlock()` relies on validation that happens in `ContextualCheckBlock()` and
`ContextualCheckBlockHeader()`. This has implications for implementing consensus
changes and handling software upgrade to ensure that nodes upgrading their
software end up enforcing all the consensus rules.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markblundeberg created this revision.Jul 7 2019, 16:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 7 2019, 16:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

A rather interesting point brought up by these comments. When SigOps counting is removed, we should think carefully about this stuff (from what I can tell on first glance, it should be fine to move all SigOps counting from CheckBlock to ContextualCheckBlock, but need to think very carefully about this stuff).

That said, this is probably only an issue if you get miners who upgrade too late and happen to start building on invalid blocks.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6708: Diff 10053.Jul 7 2019, 16:13

Fabien accepted this revision.Jul 8 2019, 06:37

This revision is now accepted and ready to land.Jul 8 2019, 06:37

Closed by commit rABC19b78ad7ca3c: Merge #11737: Document partial validation in ConnectBlock() (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyJul 8 2019, 13:57

This revision was automatically updated to reflect the committed changes.

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABC19b78ad7ca3c: Merge #11737: Document partial validation in ConnectBlock().

markblundeberg mentioned this in D3676: fix backported comment placement.Jul 15 2019, 15:04

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rABC96a1750db941: fix backported comment placement.Jul 15 2019, 16:02

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING19b78ad7ca3c: Merge #11737: Document partial validation in ConnectBlock().Sep 19 2019, 01:02

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGING96a1750db941: fix backported comment placement.Sep 19 2019, 01:16