HomePhabricator

Merge #13148: logging: Fix potential use-after-free in LogPrintStr(...)

Description

Merge #13148: logging: Fix potential use-after-free in LogPrintStr(...)

Summary:
0bd4cd3 logging: remove unused return value from LogPrintStr (practicalswift)
76f344d logging: Fix potential use-after-free in LogPrintStr(...) (practicalswift)

Pull request description:

Fix potential use-after-free in `LogPrintStr(...)`.

`freopen(…)` frees `m_fileout`.

Tree-SHA512: ceee1f659c10a21525aa648377afeea0a37016339f5269dea54850ba3b475aa316f4931081655717b65f981598fdc9d79a1e79e55f7084c242eeb7bf372bc4b6

Backport of Core PR13148
https://github.com/bitcoin/bitcoin/pull/13148/

Test Plan:

make check

Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: deadalnix, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D3976

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on May 3 2018, 10:53
nakihitoCommitted on Sep 3 2019, 17:32
jasonbcoxPushed on Sep 4 2019, 14:38
Reviewer
Restricted Owners Package
Differential Revision
D3976: Merge #13148: logging: Fix potential use-after-free in LogPrintStr(...)
Parents
rSTAGING1bf9852e2c50: Default to defining endian-conversion DECLs in compat w/o config
Branches
Unknown
Tags
Unknown