HomePhabricator

Fixed sanitizers to compiled OK with Qt enabled
206f9daafe4aUnpublished

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

Fixed sanitizers to compiled OK with Qt enabled

Summary:
Apparently I neglected to test sanitizer support with Qt libs enabled.

It breaks because the LDFLAGS weren't specified in configure.ac.

This has been fixed now and sanitizer support should 100% work.

Note there is still an issue with TSAN (thread sanitizer) on some versions of Linux and gcc. For best results use gcc 7.x for TSAN support. Also TSAN only works on 64bit architectures.

Test Plan:
./configure --enable-asan --with-gui=qt5 or whatever, then make check, then also rpc-tests.py -extended
./configure --enable-ubsan --with-gui=qt5 or whatever, then make check, then also rpc-tests.py -extended
./configure --enable-tsan --with-gui=qt5 or whatever, then make check, then also rpc-tests.py -extended

Reviewers: deadalnix, freetrader, #bitcoin_abc, sickpig

Reviewed By: deadalnix, #bitcoin_abc, sickpig

Differential Revision: https://reviews.bitcoinabc.org/D481

Details

Provenance
CCulianuAuthored on Aug 24 2017, 10:55
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Reviewer
Restricted Project
Differential Revision
D481: Fixed sanitizers to compiled OK with Qt enabled
Parents
rSTAGING0ee4822fbc31: Add fork block checkpoints and update defaultAssumedValid and min chain work…
Branches
Unknown
Tags
Unknown