HomePhabricator

[tests] Make NodeConnCB a subclass of NodeConn

Description

[tests] Make NodeConnCB a subclass of NodeConn

Summary:
This makes NodeConnCB a subclass of NodeConn, and
removes the need for the client code to know
anything about the implementation details of NodeConnCB.

NodeConn can now be swapped out for any other implementation
of a low-level connection without changing client code.

Partial backport of core PR11712 (commit dad596f)

Depends on D2359

Test Plan:

./test/functional/test_runner.py --extended

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: teamcity, schancel

Differential Revision: https://reviews.bitcoinabc.org/D2360

Details

Provenance
John Newbery <john@johnnewbery.com>Authored on Nov 17 2017, 20:01
FabienCommitted on Jan 22 2019, 17:14
FabienPushed on Jan 22 2019, 21:29
Reviewer
Restricted Project
Differential Revision
D2360: [tests] Make NodeConnCB a subclass of NodeConn
Parents
rSTAGINGec708a35e20c: [tests] Move only: move NodeConnCB below NodeConn
Branches
Unknown
Tags
Unknown