Page MenuHomePhabricator
Differential D2360

[tests] Make NodeConnCB a subclass of NodeConn
ClosedPublic
Actions

Authored by Fabien on Jan 21 2019, 10:41.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING241b424b78d0: [tests] Make NodeConnCB a subclass of NodeConn
rABC241b424b78d0: [tests] Make NodeConnCB a subclass of NodeConn
Summary

This makes NodeConnCB a subclass of NodeConn, and
removes the need for the client code to know
anything about the implementation details of NodeConnCB.

NodeConn can now be swapped out for any other implementation
of a low-level connection without changing client code.

Partial backport of core PR11712 (commit dad596f)

Depends on D2359

Test Plan
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 21 2019, 10:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 21 2019, 10:41
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 21 2019, 10:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added a child revision: D2361: [tests] Move version message sending from NodeConn to NodeConnCB.Jan 21 2019, 10:48
teamcity added a comment.Jan 21 2019, 10:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4605: Diff 6775.Jan 21 2019, 10:51
deadalnix accepted this revision.Jan 21 2019, 17:20
This revision is now accepted and ready to land.Jan 21 2019, 17:20
Closed by commit rABC241b424b78d0: [tests] Make NodeConnCB a subclass of NodeConn (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyJan 22 2019, 17:14
This revision was automatically updated to reflect the committed changes.
Fabien mentioned this in T471: Backport Core PR11712.Jul 7 2019, 17:06
Fabien added a commit: rSTAGING241b424b78d0: [tests] Make NodeConnCB a subclass of NodeConn.Sep 18 2019, 22:00

Revision Contents
Changeset List

PathSize
test/
functional/
10 lines
3 lines
2 lines
4 lines
4 lines
12 lines
2 lines
63 lines
2 lines
10 lines
test_framework/
128 lines
129 lines
14 lines

Diff 6834

View Options

test/functional/abc-p2p-compactblocks.py

Loading...
View Options

test/functional/abc-sync-chain.py

Loading...
View Options

test/functional/assumevalid.py

Loading...
View Options

test/functional/example_test.py

Loading...
View Options

test/functional/maxuploadtarget.py

Loading...
View Options

test/functional/p2p-compactblocks.py

Loading...
View Options

test/functional/p2p-feefilter.py

Loading...
View Options

test/functional/p2p-leaktests.py

Loading...
View Options

test/functional/p2p-timeouts.py

Loading...
View Options

test/functional/sendheaders.py

Loading...
View Options

test/functional/test_framework/comptool.py

Loading...
View Options

test/functional/test_framework/mininode.py

Loading...
View Options

test/functional/test_framework/test_node.py

Loading...