Page MenuHomePhabricator
Differential D2361

[tests] Move version message sending from NodeConn to NodeConnCB
ClosedPublic
Actions

Authored by Fabien on Jan 21 2019, 10:48.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGebbbfeb41a1a: [tests] Move version message sending from NodeConn to NodeConnCB
rABCebbbfeb41a1a: [tests] Move version message sending from NodeConn to NodeConnCB
Summary

This commit moves the logic that sends a version message
on connection from NodeConn to NodeConnCB. NodeConn should
not be aware of the semantics or meaning of the P2P payloads.

Partial backport of core PR11712 (commit e9dfa9b)

Depends on D2360

Test Plan
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 21 2019, 10:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 21 2019, 10:48
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 21 2019, 10:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 21 2019, 10:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4606: Diff 6776.Jan 21 2019, 10:58
Fabien added a child revision: D2362: [tests] Rename NodeConn and NodeConnCB.Jan 21 2019, 11:42
deadalnix accepted this revision.Jan 21 2019, 17:22
This revision is now accepted and ready to land.Jan 21 2019, 17:22
Closed by commit rABCebbbfeb41a1a: [tests] Move version message sending from NodeConn to NodeConnCB (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyJan 22 2019, 17:18
This revision was automatically updated to reflect the committed changes.
Fabien mentioned this in T471: Backport Core PR11712.Jul 7 2019, 17:06
Fabien added a commit: rSTAGINGebbbfeb41a1a: [tests] Move version message sending from NodeConn to NodeConnCB.Sep 18 2019, 22:00

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
25 lines

Diff 6835

View Options

test/functional/test_framework/mininode.py

Loading...