[tests] define NODE_NETWORK_LIMITED in test framework
ClosedPublic
Actions

Authored by Fabien on Jan 21 2019, 16:18.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING0c21fb351ed2: [tests] define NODE_NETWORK_LIMITED in test framework
rABC0c21fb351ed2: [tests] define NODE_NETWORK_LIMITED in test framework

Summary

This makes the bitfields comparison easier to work with.

Partial Backport of core PR11867 (commit dbfe294)

Depends on D2366

Test Plan

./test/functional/test_runner.py node_network_limited.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 21 2019, 16:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 21 2019, 16:18

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added a child revision: D2368: [tests] node_network_limited - remove race condition.Jan 21 2019, 16:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4612: Diff 6782.Jan 21 2019, 16:27

The description is incorrect.

test/functional/node_network_limited.py
53 ↗	(On Diff #6782)	Fix the comment. Note that NODE_BITCOIN_CASH is deprecated and has no effect now.

This revision now requires changes to proceed.Jan 21 2019, 17:32

Fix comment

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4618: Diff 6791.Jan 21 2019, 18:10

deadalnix accepted this revision.Jan 21 2019, 23:34

deadalnix edited the summary of this revision. (Show Details)

This revision is now accepted and ready to land.Jan 21 2019, 23:36

Closed by commit rABC0c21fb351ed2: [tests] define NODE_NETWORK_LIMITED in test framework (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyJan 22 2019, 18:34

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rSTAGING0c21fb351ed2: [tests] define NODE_NETWORK_LIMITED in test framework.Sep 18 2019, 22:01

Revision Contents
Changeset List

Path

Size

test/

functional/

node_network_limited.py

17 lines

test_framework/

messages.py

3 lines

Diff 6840

View Options

test/functional/node_network_limited.py