Differential D2362

[tests] Rename NodeConn and NodeConnCB
ClosedPublic
Actions

Authored by Fabien on Jan 21 2019, 11:42.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING508b134cf8d6: [tests] Rename NodeConn and NodeConnCB
rABC508b134cf8d6: [tests] Rename NodeConn and NodeConnCB

Summary

NodeConn -> P2PConnection
NodeConnCB -> P2PInterface

Backport of core PR11791

Depends on D2361

Test Plan

./test/functional/test_runner.py --extended

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 21 2019, 11:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 21 2019, 11:42

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4607: Diff 6777.Jan 21 2019, 11:52

Fabien added a child revision: D2363: Implement BIP159 NODE_NETWORK_LIMITED (pruned peers) *signaling only*.Jan 21 2019, 13:01

deadalnix accepted this revision.Jan 21 2019, 17:25

This revision is now accepted and ready to land.Jan 21 2019, 17:25

Closed by commit rABC508b134cf8d6: [tests] Rename NodeConn and NodeConnCB (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyJan 22 2019, 17:19

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rSTAGING508b134cf8d6: [tests] Rename NodeConn and NodeConnCB.Sep 18 2019, 22:00

Revision Contents
Changeset List

Path

Size

doc/

functional-tests.md

10 lines

test/

functional/

abc-p2p-compactblocks.py

2 lines

5 lines

4 lines

2 lines

2 lines

20 lines

3 lines

12 lines

2 lines

2 lines

4 lines

2 lines

2 lines

2 lines

2 lines

test_framework/

comptool.py

2 lines

mininode.py

22 lines

Diff 6836

View Options

doc/functional-tests.md

View Options

test/functional/abc-p2p-compactblocks.py

View Options

test/functional/abc-sync-chain.py

View Options

test/functional/assumevalid.py

View Options

test/functional/bip65-cltv-p2p.py

View Options

test/functional/bipdersig-p2p.py

View Options

test/functional/example_test.py

View Options

test/functional/maxuploadtarget.py

View Options

test/functional/p2p-acceptblock.py

View Options

test/functional/p2p-compactblocks.py

View Options

test/functional/p2p-feefilter.py

View Options

test/functional/p2p-fingerprint.py

View Options

test/functional/p2p-leaktests.py

View Options

test/functional/p2p-mempool.py

View Options

test/functional/p2p-timeouts.py

View Options

test/functional/sendheaders.py

View Options

test/functional/test_framework/comptool.py

View Options

test/functional/test_framework/mininode.py

[tests] Rename NodeConn and NodeConnCBClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 6836

doc/functional-tests.md

test/functional/abc-p2p-compactblocks.py

test/functional/abc-sync-chain.py

test/functional/assumevalid.py

test/functional/bip65-cltv-p2p.py

test/functional/bipdersig-p2p.py

test/functional/example_test.py

test/functional/maxuploadtarget.py

test/functional/p2p-acceptblock.py

test/functional/p2p-compactblocks.py

test/functional/p2p-feefilter.py

test/functional/p2p-fingerprint.py

test/functional/p2p-leaktests.py

test/functional/p2p-mempool.py

test/functional/p2p-timeouts.py

test/functional/sendheaders.py

test/functional/test_framework/comptool.py

test/functional/test_framework/mininode.py

[tests] Rename NodeConn and NodeConnCB
ClosedPublic
Actions

Revision Contents
Changeset List