HomePhabricator

[tests] Move version message sending from NodeConn to NodeConnCB

Description

[tests] Move version message sending from NodeConn to NodeConnCB

Summary:
This commit moves the logic that sends a version message
on connection from NodeConn to NodeConnCB. NodeConn should
not be aware of the semantics or meaning of the P2P payloads.

Partial backport of core PR11712 (commit e9dfa9b)

Depends on D2360

Test Plan:

./test/functional/test_runner.py

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: teamcity, schancel

Differential Revision: https://reviews.bitcoinabc.org/D2361

Details

Provenance
John Newbery <john@johnnewbery.com>Authored on Oct 17 2017, 19:56
FabienCommitted on Jan 22 2019, 17:18
FabienPushed on Jan 22 2019, 17:18
Reviewer
Restricted Project
Differential Revision
D2361: [tests] Move version message sending from NodeConn to NodeConnCB
Parents
rABC241b424b78d0: [tests] Make NodeConnCB a subclass of NodeConn
Branches
Unknown
Tags
Unknown