Page MenuHomePhabricator

[tests] Move version message sending from NodeConn to NodeConnCB
ClosedPublic

Authored by Fabien on Jan 21 2019, 10:48.

Details

Summary

This commit moves the logic that sends a version message
on connection from NodeConn to NodeConnCB. NodeConn should
not be aware of the semantics or meaning of the P2P payloads.

Partial backport of core PR11712 (commit e9dfa9b)

Depends on D2360

Test Plan
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11712_part5
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4606
Build 7275: Bitcoin ABC Buildbot (legacy)
Build 7274: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jan 21 2019, 17:22
This revision was automatically updated to reflect the committed changes.