HomePhabricator

[CMAKE] Pull miniupnpc windows library dependencies in the find module

Description

[CMAKE] Pull miniupnpc windows library dependencies in the find module

Summary:
This is quite identical to what is done with libevent. It prevents from
managing the dependencies at the project level.

The definitions are kept at project level since there are assuming that
we build using the depends, which should always be the case for now but
is not a library requirement. A comment is added to explain this.

Depends on D5576.

Test Plan:
Build for windows. Run the binaries and check the UPnP functions are
available.

Run the windows Gitian build.

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D5575

Details

Provenance
FabienAuthored on Mar 26 2020, 16:19
deadalnixPushed on Mar 29 2020, 16:02
Reviewer
Restricted Project
Differential Revision
D5575: [CMAKE] Pull miniupnpc windows library dependencies in the find module
Parents
rSTAGINGb511395ba352: [CMAKE] Pass the interface linked libraries to find_component
Branches
Unknown
Tags
Unknown