HomePhabricator
Diffusion Bitcoin ABC staging 2f7d52036fe7

Update the undo operation so they return a success/error code rather than…
2f7d52036fe7Unpublished
Actions

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

Update the undo operation so they return a success/error code rather than taking out parameter

Summary:
This is backport from core. It makes the API much more understandable. See https://github.com/bitcoin/bitcoin/pull/10297/commits/db994b2de93f52c9e7bed8529ca925de5064a46f for details.

I would rather return some object that forces you to check, but we have this and it is needed for the utxo work, so be it.

Test Plan:

make check
../qa/pull-tester/rpc-tests.py -extended

Reviewers: freetrader, #bitcoin_abc

Reviewed By: freetrader, #bitcoin_abc

Subscribers: CCulianu

Differential Revision: https://reviews.bitcoinabc.org/D364

Details

Provenance
deadalnixAuthored on Jul 21 2017, 16:52
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Reviewer
Restricted Project
Differential Revision
D364: Update the undo operation so they return a success/error code rather than taking out parameter
Parents
rSTAGINGbfd7b2222ef0: Add NODE_BITCOIN_CASH service bit
Branches
Unknown
Tags
Unknown

Changes (5)

PathSize
src/
test/

rSTAGING2f7d52036fe7

View Options

src/test/coins_tests.cpp

Loading...
View Options

src/test/undo_tests.cpp

Loading...
View Options

src/undo.h

Loading...
View Options

src/validation.cpp

Loading...
View Options

src/validation.h

Loading...