HomePhabricator

[wallet] fix zapwallettxes interaction with persistent mempool

Description

[wallet] fix zapwallettxes interaction with persistent mempool

Summary:
Backport Core PR10330: [wallet] fix zapwallettxes interaction with persistent mempool

4c3b538 [logs] fix zapwallettxes startup logs (John Newbery)
e7a2181 [wallet] fix zapwallettxes interaction with persistent mempool (John Newbery)
ff7365e [tests] fix flake8 warnings in zapwallettxes.py (John Newbery)

Pull request description:

zapwallettxes previously did not interact well with persistent mempool.
zapwallettxes would cause wallet transactions to be zapped, but they
would then be reloaded from the mempool on startup. This commit softsets
persistmempool to false if zapwallettxes is enabled so transactions are
actually zapped.

Test Plan:

make check
./test/functional/test_runner.py zapwallettxes

Reviewers: #bitcoin_abc, schancel

Reviewed By: #bitcoin_abc, schancel

Subscribers: teamcity

Differential Revision: https://reviews.bitcoinabc.org/D1061

Details

Provenance
John Newbery <john@johnnewbery.com>Authored on May 3 2017, 15:49
deadalnixCommitted on Feb 3 2018, 14:02
deadalnixPushed on Feb 3 2018, 16:40
Reviewer
Restricted Project
Differential Revision
D1061: [wallet] fix zapwallettxes interaction with persistent mempool
Parents
rSTAGINGfd681de9408f: [wallet] [refactor] Simplify getbalance implementation
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/2810