HomePhabricator

Merge #11866: Do not un-mark fInMempool on wallet txn if ATMP fails.

Description

Merge #11866: Do not un-mark fInMempool on wallet txn if ATMP fails.

Summary:
6ef86c9 Do not un-mark fInMempool on wallet txn if ATMP fails. (Matt Corallo)

Pull request description:

Irrespective of the failure reason, un-marking fInMempool
out-of-order is incorrect - it should be unmarked when
TransactionRemovedFromMempool fires.

Clean up of #11839, which I think was the wrong fix.

Tree-SHA512: 580731297eeac4c4c99ec695e15b09febf62249237bc367fcd1830fc811d3166f9336e7aba7f2f6f8601960984ae22cebed781200db0f04e7cd2008db1a83f64

Backport of Core PR11866
https://github.com/bitcoin/bitcoin/pull/11866/

Test Plan:

make check

Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc, markblundeberg

Reviewed By: Fabien, O1 Bitcoin ABC, #bitcoin_abc, markblundeberg

Differential Revision: https://reviews.bitcoinabc.org/D4733

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Feb 14 2018, 15:52
nakihitoCommitted on Dec 17 2019, 18:42
jasonbcoxPushed on Dec 17 2019, 19:43
Reviewer
Restricted Owners Package
Differential Revision
D4733: Merge #11866: Do not un-mark fInMempool on wallet txn if ATMP fails.
Parents
rSTAGING0016b3eb5626: test: Move main_tests to validation_tests
Branches
Unknown
Tags
Unknown